track/trophies index returns a JSON object, not a list

[glennj]

as per discord discussion

[glennj]

@ihid, I was awkwardly force pushing while the checks were running. I think I have the tests correct now. Can you re-run the checks?

[glennj]

Note to self:

--- expected
+++ actual
@@ -1 +1 @@
-{:trophies=>[{:name=>"Magnificent Mentee", :criteria=>"Awarded once you complete a mentoring session in Ruby", :success_message=>"Congratulations on completing a mentoring session in Ruby. Our mentors are always here to help and guide you!", :icon_name=>"trophy-mentored", :num_awardees=>0, :awarded_at=>nil, :status=>:not_earned, :links=>{}, :track=>{:title=>"Ruby"}}]}
+{:trophies=>[{:name=>"Magnificent Mentee", :criteria=>"Awarded once you complete a mentoring session in Ruby", :success_message=>"Congratulations on completing a mentoring session in Ruby. Our mentors are always here to help and guide you!", :icon_name=>"trophy-mentored", :num_awardees=>0, :awarded_at=>nil, :status=>"not_earned", :links=>{}, :track=>{:title=>"Ruby"}}]}

• expected: ..., :status=>:not_earned, ...
• actual: ..., :status=>"not_earned", ...

Todo: compare with other serializers and tests to ensure I'm encoding/decoding correctly.

[glennj]

Is the remaining failed check ("test/system/flows/student/finish_mentor_discussion/happy_test.rb") typical? It's outside of what I touched.

[iHiD]

typical

Not typical, but occasionally system tests do fail on GH.

Merged. Thanks! :)