search

exercism / x86-64-assembly

Exercism exercises in x86-64 Assembly.
https://exercism.org/tracks/x86-64-assembly
MIT License
22 stars 18 forks source link

Launch tracking #1

Closed kytrinyx closed 5 years ago

kytrinyx commented 5 years ago

Edit this issue to keep track of the tasks you're working on towards launch.

We have a rough guide for how to launch a track, which is sorely outdated but quite possibly better than nothing (I'm so sorry, I'm waaaay behind on getting documentation updated). https://github.com/exercism/docs/blob/master/language-tracks/launch/README.md

Check out https://github.com/orgs/exercism/teams/track-maintainers/discussions/1 for details about the #maintainers channel in the exercism-team Slack workspace.

Please ask if you have any questions or if anything is confusing!

kotp commented 5 years ago

Should this repository be named x86_Assembly? I think x86 is an architecture, while Assembly is the language, and while both are important, the first doesn't answer "What language are we practicing?"

kytrinyx commented 5 years ago

That would make sense to me. @bergjohan -- your call, I think!

bergjohan commented 5 years ago

@kytrinyx I agree with @kotp and I think we should make the change, but I think we should use all lowercase and dash instead of underscore to follow the naming convention of other exercism repositories. So the name would be x86-assembly.

kytrinyx commented 5 years ago

x86-assembly it is! Changing it now.

bergjohan commented 5 years ago

@kytrinyx Thanks! :) Should we update the track id (config.json, .travis.yml), travis-ci (README.md) and the team name aswell for consistency?

kotp commented 5 years ago

Thought of something else as well, when "assembly" is the immediately interesting part (such as mirrored by perl5/perl6) should Assembly as the language be first, while the architecture choice is second? Not sure how the two flavors are normally referenced.

bergjohan commented 5 years ago

@kotp I understand what you mean, but I don't think I've ever seen it written that way. I think we should stick with the current name.

kotp commented 5 years ago

I think that is definitely fine, as the search on the site (exercism) for "assem" will pull them both up.

kytrinyx commented 5 years ago

Should we update the track id (config.json, .travis.yml), travis-ci (README.md) and the team name aswell for consistency?

D'oh, I was thinking "oh, this is easy because we're not yet integrated into the site" /facepalm.

Yes, we definitely want to update the config file, etc. Sorry about that.

bergjohan commented 5 years ago

@kytrinyx Hi, I saw you updated README.md in https://github.com/exercism/x86-assembly/commit/03e3fe708fdb53995c67d2e2ba5127b0affc14aa. You made a change to "x686-assembly.svg", should it really say "x686"?

kytrinyx commented 5 years ago

No, that's a typo.

bergjohan commented 5 years ago

Okay, thank you for fixing it :)

bergjohan commented 5 years ago

Hi @kytrinyx,

Yesterday I read that macOS Mojave "is the final version of macOS to support 32-bit application software", https://en.wikipedia.org/wiki/MacOS_Mojave. Based on that I think it's better to use 64-bit assembly for this track. This unfortunately means that we should rename the track again to reflect that.

There are a few different names used for 64-bit x86 assembly, x86-64, x64, x86_64, AMD64 and Intel 64. Searching around the most commonly used seems to be x86_64 and x86-64.

I suggest using either x86_64-assembly or x86-64_assembly as the track name.

If you agree with me, would you mind updating the track repository, the team repository and Travis? Hopefully this will be for the last time, but I think it's better to get it right from the beginning than having to change it later.

bergjohan commented 5 years ago

Hi again @kytrinyx,

I merged a branch to master yesterday, which should have made the Travis CI build pass. It still shows "build failing" though, and the latest build seems to have run after your "Fix typo" commit. Do you know why no build was run after the merge to master?

kytrinyx commented 5 years ago

We don't use underscores in track names, so I would prefer x86-64-assembly. How does that sound?

kytrinyx commented 5 years ago

Do you know why no build was run after the merge to master?

Ah, I wonder if builds only run for PRs right now, not for branches. We have a ton of repos and lots of activity, and when it runs for both PRs and branches we use double the amount of Travis resources, which means that everything takes twice as long.

I could switch to running for branches only, and not PRs, and see if that would help.

The other thing I can do is to enable the setting which says that a PR must be up to date with master before merging.

bergjohan commented 5 years ago

We don't use underscores in track names, so I would prefer x86-64-assembly. How does that sound?

@kytrinyx Alright, x86-64-assembly sounds good! :)

bergjohan commented 5 years ago

Ah, I wonder if builds only run for PRs right now, not for branches. We have a ton of repos and lots of activity, and when it runs for both PRs and branches we use double the amount of Travis resources, which means that everything takes twice as long.

I could switch to running for branches only, and not PRs, and see if that would help.

The other thing I can do is to enable the setting which says that a PR must be up to date with master before merging.

@kytrinyx Ah okay! Thanks, but you can leave it as it is. It's more interesting to know if the tests are passing on a PR :)

kytrinyx commented 5 years ago

Alright, x86-64-assembly sounds good! :)

Cool, I'll change the repo name, and leave you to update the various files that need adjustment.

bergjohan commented 5 years ago

@kytrinyx Perfect, thank you! :) Could you change the team name aswell?

bergjohan commented 5 years ago

@kytrinyx @iHiD I'm thinking of launching this track, what do you think, am I missing something, what's the next step?

iHiD commented 5 years ago

This looks excellent. I really like the core track. Do we have an icon made yet?

bergjohan commented 5 years ago

@iHiD Thank you! :) The icon can be found here: https://github.com/exercism/website-icons/issues/30