Closed sudhackar closed 2 years ago
Thanks! One for you too @bergjohan
ping @bergjohan
Thanks for the PR, looks good!
@ErikSchierboom Feel free to approve and merge it!
Wait, could you update the assembly files with the changes in https://github.com/exercism/x86-64-assembly/pull/161 before merging?
Done. Updated the example solution and the template.
Perfect, thank you!
Wait, there seems to be an error on macOS:
triangle.asm:95: error: segment name `.note.GNU-stack' not recognized
Try the following instead:
%ifidn __OUTPUT_FORMAT__,elf64
section .note.GNU-stack noalloc noexec nowrite progbits
%endif
@bergjohan or @ErikSchierboom Can you approve the CI workflow on #161. Lets see once that change is tested and fixed.
@bergjohan Done. Looks to be good. Want me to merge?
Yes you can merge it, thank you!
Adding another exercise triangle : https://github.com/exercism/problem-specifications/tree/main/exercises/triangle
This adds the concepts for handling floats in assembly.
Additionally I might raise a bug in generator - when we flatten the array, we lose the context of tests. Worked with the following diff