search

exercism / x86-64-assembly

Exercism exercises in x86-64 Assembly.
https://exercism.org/tracks/x86-64-assembly
MIT License
22 stars 18 forks source link

Add all your base exercise #219

Closed kahgoh closed 2 months ago

kahgoh commented 3 months ago

This is one of the 48in24 exercises

github-actions[bot] commented 3 months ago

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

ErikSchierboom commented 3 months ago

@kahgoh The tests seem to be failing. Could you look into that?

kahgoh commented 3 months ago

@ErikSchierboom I've just pushed the fixes.

ErikSchierboom commented 3 months ago

Still seems to fail:

all_your_base_test.c:24:test_single_bit_one_to_decimal:FAIL: Element 0 Expected 1 Was 0
all_your_base_test.c:33:test_binary_to_single_decimal:FAIL: Expected 1 Was 5
all_your_base_test.c:43:test_single_decimal_to_binary:FAIL: Expected 3 Was 1
all_your_base_test.c:53:test_binary_to_multiple_decimal:FAIL: Expected 2 Was 4
all_your_base_test.c:63:test_decimal_to_binary:FAIL: Expected 6 Was 1
all_your_base_test.c:74:test_trinary_to_hexadecimal:FAIL: Element 0 Expected 2 Was 0
all_your_base_test.c:83:test_hexadecimal_to_trinary:FAIL: Expected 4 Was 2
all_your_base_test.c:93:test_15bit_integer:FAIL: Expected 3 Was 45
all_your_base_test.c:103:test_empty_list:FAIL: Expected 1 Was -1240367940
all_your_base_test.c:113:test_single_zero:FAIL: Expected 1 Was -1240367940
all_your_base_test.c:123:test_multiple_zeros:FAIL: Expected 1 Was -1240367940
all_your_base_test.c:133:test_leading_zeros:FAIL: Expected 2 Was 4
all_your_base_test.c:142:test_input_base_is_one:FAIL: Expected -1 Was -1240367524
all_your_base_test.c:150:test_input_base_is_zero:FAIL: Expected -1 Was 0
all_your_base_test.c:158:test_input_base_is_negative:FAIL: Expected -1 Was 1
all_your_base_test.c:166:test_negative_digit:FAIL: Expected -2 Was 1
all_your_base_test.c:174:test_invalid_positive_digit:FAIL: Expected -2 Was 1
all_your_base_test.c:182:test_output_base_is_one:FAIL: Expected -1 Was 1
all_your_base_test.c:190:test_output_base_is_zero:FAIL: Expected -1 Was 7
all_your_base_test.c:198:test_output_base_is_negative:FAIL: Expected -1 Was 1
make: *** [Makefile:29: all] Error [21](https://github.com/exercism/x86-64-assembly/actions/runs/9384592753/job/25843210083?pr=219#step:5:22)
all_your_base_test.c:206:test_both_bases_are_negative:FAIL: Expected -1 Was 1
kahgoh commented 3 months ago

I'm not sure how I missed adding the example implementation in the commit 🤦🏻‍♂️. I've just pushed a fix.

kahgoh commented 3 months ago

I've just noticed the CI is failing for MacOS. I'm having a look into it.

kahgoh commented 3 months ago

@ErikSchierboom I've just pushed the fix for the failures. Should be ready for review again.

ErikSchierboom commented 2 months ago

I'll let @keiravillekode do the code review