Toggle Collapsed Sidebar

zinefer commented 2 years ago

Is there a way to toggle the new collapsed sidebar feature? I'm not a super big fan of it. Otherwise these new changes are looking great! Thanks!

exetico commented 2 years ago

Hi

There's no way to do a thing like that, without adding a script.

However a hot-fix could be to only use the collapsed sidebar on smaller screens and mobile-devices? I'm not sure if that would work out.

exetico commented 2 years ago

@zinefer What do you think?

zinefer commented 2 years ago

Sorry for the delayed response! Unfortunately, I ran into a couple additional bugs that irritated me into downgrading back to pre-2.0.

Thanks again for the lovely theme!

exetico commented 2 years ago

I ran into a couple additional bugs that irritated me into downgrading back to pre-2.0.

Could you add additional details on that part Details in a direct message is also fine.

zinefer commented 2 years ago

Bugs:

Many of the tabs have a gap on the right side, the appx width of the open sidebar
The sidebar icons get weird when the height drops below 780px
Sometimes the input dropdown on the traffic tab disappears

exetico commented 2 years ago

Hi again

Thanks!

Many of the tabs have a gap on the right side, the appx width of the open sidebar

I've not looked into this, but I guess that's changed due to other bugs. I'll see what's causing it, and push a fix.

Sometimes the input dropdown on the traffic tab disappears

What kind of input dropdown? I've no dropdowns - or.. Maybe I'm not used to it. To be honest, I'm not using ruTorrent for more than a few simple things right now...

The sidebar icons get weird when the height drops below 780px

What kind of browser is this? Are you adding ruTorrent as a Chromium-based webapplication (Chrome, Edge, whatever) or simular? I'm unable to reproduce the issue. I've tested on very small width in both Firefox, Edge and more.

Are you using some kind of window-scaling, which could cause the problem?

zinefer commented 2 years ago

What kind of input dropdown?

You can see it in the second screenshot I posted. In the first it is "missing".

Are you adding ruTorrent as a Chromium-based webapplication (Chrome, Edge, whatever) or simular?

Yes, but it should be rather irrelevant. That chromium function simply hides the address and bookmarks bar.

I'm unable to reproduce the issue. I've tested on very small width in both Firefox, Edge and more.

Try a small height. This issue is present for me without using the webapp flag in chrome and edge.

Are you using some kind of window-scaling, which could cause the problem?

Probably not but I'm actually only 90% on that.

exetico commented 2 years ago

What kind of input dropdown?
You can see it in the second screenshot I posted. In the first it is "missing".

Oh, these! I get it.

Tip: Consider to add markings or so. It's so much more helpful for this kind of reports.

The sidebar icons get weird when the height drops below 780px

Now I get it. That's on me. It's actually a choice I made, to prevent the page from jumping in the width - cause that's the alternative, in that cause. Would you prefer to simply have the scrollbar hidden away for the sidebar, if the height can't handle the elements? I must have considered that, but I can't remember any good reasons for not hiding the scollbar in the sidebar...

With that said; Your scrolling are HUGE compared to mine:

But that's irrelevant info, if we're just going to hide it.

zinefer commented 2 years ago

if we're just going to hide it.

Actually, now that you show me the true issue, a min-height on body so the whole page gets a scroll may make more sense here? Somehow my brain really did not recognize that as a scrollbar until now.

Oh, these! I get it.

It also would have helped if I wasn't wrong in telling you which screenshot to look at. I'm having a rough morning.

exetico / FlatUI

Toggle Collapsed Sidebar #8