search

exflickr / flamework

Flickr-style PHP Framework
BSD 2-Clause "Simplified" License
118 stars 32 forks source link

(the dotspotting pull request) #5

Closed straup closed 14 years ago

straup commented 14 years ago

A few open questions:

1) I've added bare-bones sign in/out/up pages along with the corresponding password forget/reset pages and account delete change password pages.

The code uses lib_sanitize which is not part of the flamework core and still marked as "scary". Is there a plan to merge it in core or ... ? (It would be easy enough to stick some stub get/post_str functions in init.php)

2) DB schemas -- where should they go exactly?

Let the bickering begin!

iamcal commented 14 years ago

(this queue terrifies me)

1) lib_sanitize can be imported 2) hmm, /schema/ ?

iamcal commented 14 years ago

also, can you go back and fix the user on your commits before i pull this? google can tell you how

straup commented 14 years ago

I imported lib_sanitize and added a schema directory with a .htaccess file.

When you say "fix the user" are you talking the username (asc) here:

http://github.com/exflickr/flamework/pull/5#commits-pushed-5bf60f1

iamcal commented 14 years ago

why yes, yes i am