search

exgalsky / xgfield

Generation of mocks from a field representation of LSS on the observer's past light cone.
GNU General Public License v3.0
0 stars 0 forks source link

External cosmology workspace #7

Closed marcelo-alvarez closed 9 months ago

marcelo-alvarez commented 9 months ago

Modifies the FieldSky class to be initialized with an external cosmology workspace.

marcelo-alvarez commented 9 months ago

Good catch @1cosmologist, indeed I forgot to commit and push that change. It should be as intended now. Please have another look. Thanks.

1cosmologist commented 9 months ago

@marcelo-alvarez did you run the entire pipeline with the external cosmology workspace in the code without a crash. In that case we open an issue for the external backend, documenting the crash and merge this PR.

marcelo-alvarez commented 9 months ago

@1cosmologist it may be useful to attempt to reproduce / document the backend problem from the previous commit, although it's probably more useful to consider how best to approach having a consistent backend in the pipeline as part of a longer term, higher level refactor.

marcelo-alvarez commented 9 months ago

And to answer the question, I did run it without a crash. However, it would be helpful if you could verify this before merging the relevant PRs.

1cosmologist commented 9 months ago

It would be good to actually run this but I'm still without resources on MP107. I have heard it will take till the end of the week for the resource availablity to be solved.

marcelo-alvarez commented 9 months ago

Merging this now, thanks @1cosmologist for the review.