search

exhibitionist-digital / ultra

Zero-Legacy Deno/React Suspense SSR Framework
https://ultrajs.dev
MIT License
3k stars 67 forks source link

wip: Add create-ultra-app to repo #151

Closed b3nten closed 2 years ago

b3nten commented 2 years ago
deckchairlabs commented 2 years ago

Whats the status of this, is it ready to merge?

deckchairlabs commented 2 years ago

One tiny request, can we get some color on the questions asked? Maybe the same blue used in the "congrats" message at the end

b3nten commented 2 years ago

Will need to update the imports to link to the files in this repo, and some of the templates need to be tested to make sure they work.

Also I think long term it might be best to create locally the required components rather than importing them. I thought it might be too messy but I think the explicitness of it might be better. It's something we can ponder in the meantime.

cdoremus commented 2 years ago

Great job Benton! 🚀🚀🚀

b3nten commented 2 years ago

I think we should, at least for now, go the route of creating all required files locally.

deckchairlabs commented 2 years ago

I think we should, at least for now, go the route of creating all required files locally.

Is this in reference to the files that are downloaded from the repo?

benton-droplab commented 2 years ago

I think we should, at least for now, go the route of creating all required files locally.

Is this in reference to the files that are downloaded from the repo?

The files in modules that are imported rather than created. For example, useFlushAsyncWhateverTheNameIs

deckchairlabs commented 2 years ago

Oh no, right I see what you mean. Yeah I'd like the files to be local, gives developers a chance to modify if they so choose.

b3nten commented 2 years ago

Oh no, right I see what you mean. Yeah I'd like the files to be local, gives developers a chance to modify if they so choose.

Should be a trivial change, I can push something up tonight.

For the Twind issue that was resolved, was there something in particular that was implemented wrong?

deckchairlabs commented 2 years ago

Oh no, right I see what you mean. Yeah I'd like the files to be local, gives developers a chance to modify if they so choose.

Should be a trivial change, I can push something up tonight.

For the Twind issue that was resolved, was there something in particular that was implemented wrong?

@mashaal best to answer that

mashaal commented 2 years ago

Oh no, right I see what you mean. Yeah I'd like the files to be local, gives developers a chance to modify if they so choose.

Should be a trivial change, I can push something up tonight.

For the Twind issue that was resolved, was there something in particular that was implemented wrong?

It seems it was missing the twind.ts Deno block here. https://github.com/exhibitionist-digital/ultra/blob/main/examples/with-twind/twind.ts#L4-L12

And then I got a useDehydratedState issue with react-query. https://github.com/exhibitionist-digital/ultra/blob/main/examples/with-react-query/src/hooks/useDehydrateReactQuery.tsx

That issue raised covered a heap of surface area. react-query, react-router, trpc, twind, helmet -- I was able to get it to work after a few mins of localising the twind and query dependencies, but I'm certain this level of integration could be a bit more elegant. https://github.com/exhibitionist-digital/ultra/issues/153

b3nten commented 2 years ago

Oh no, right I see what you mean. Yeah I'd like the files to be local, gives developers a chance to modify if they so choose.

Should be a trivial change, I can push something up tonight. For the Twind issue that was resolved, was there something in particular that was implemented wrong?

It seems it was missing the twind.ts Deno block here. https://github.com/exhibitionist-digital/ultra/blob/main/examples/with-twind/twind.ts#L4-L12

And then I got a useDehydratedState issue with react-query. https://github.com/exhibitionist-digital/ultra/blob/main/examples/with-react-query/src/hooks/useDehydrateReactQuery.tsx

That issue raised covered a heap of surface area. react-query, react-router, trpc, twind, helmet -- I was able to get it to work after a few mins of localising the twind and query dependencies, but I'm certain this level of integration could be a bit more elegant. #153

sheet should have been provided here https://github.com/B3nten/ultra/blob/create/lib/create/modules/twind/content/twind.ts

But regardless it was missing useDehydrateReactQuery which was obviously an issue. I'll try to get something up tonight that should fix those issues. And try to make it more elegant

b3nten commented 2 years ago

Okay, I think this is ready to merge. The current create script is broken so this wouldn't be any worse. I've disabled TRPC until I can confirm it works.