exhibitionist-digital / ultra

Zero-Legacy Deno/React Suspense SSR Framework
https://ultrajs.dev
MIT License
2.99k stars 66 forks source link

The `ignored` option is not working #221

Closed rojvv closed 1 year ago

rojvv commented 1 year ago

No file or directory can be ignored when building.

deckchairlabs commented 1 year ago

Hey @roj1512 thanks for reporting, could you please add a reproduction of your build config?

deckchairlabs commented 1 year ago

In the new release 2.1.5 if your ignore pattern ends with a / it now assumes that you want to deeply ignore anything matching that pattern!

So doing the below (for instance) would now work

builder.ignore('./.git/')
rojvv commented 1 year ago

Thanks, and sorry for not being so active.

rojvv commented 1 year ago

I’ve just upgraded to 2.1.5.

Here’s my config:

image

And here is the unexpected result:

image

rojvv commented 1 year ago

Wait, the .git is also not ignored. It ignores it only like you said, ./.git/. Which is kinda weird, isn’t it?

deckchairlabs commented 1 year ago

It needs to end with a slash unfortunately, just because of how https://deno.land/std@0.167.0/path/glob.ts?s=globToRegExp works

rojvv commented 1 year ago

@deckchairlabs What about https://github.com/exhibitionist-digital/ultra/issues/221#issuecomment-1337137357

rojvv commented 1 year ago

@deckchairlabs are you still with me here?

rojvv commented 1 year ago

I want to ignore single files

https://github.com/exhibitionist-digital/ultra/issues/221#issuecomment-1337137357

deckchairlabs commented 1 year ago

Hi @roj1512 yes still here! Just haven't had the time to look into a solution for this. Could you open a separate issue for ignoring single files? Thanks!

rojvv commented 1 year ago

That’s pretty fine, take your time! Sure, I’m doing it right now.

deckchairlabs commented 1 year ago

In the meantime it looks like if you make the "patterns" relative it works okay in my testing eg.

ignored: [
  "./.gitignore"
]