exile-center / better-trading

QoL improvements for the official PathOfExile trading site.
36 stars 7 forks source link

Playstation | Filters not persisted when registering trade #117

Closed lesse83 closed 2 years ago

lesse83 commented 2 years ago

Hi, first of all thanks for this amazing addon and the effort you put in.

I'm able to use the extension for the PC version of poe without flaws - however when I'm trying to register the trades for my playstation account (PS5) nothing is persisted (not the search field nor any filters).

Example: If I store a filter by filling out the fields and registering it: save

... and then double click the registered item, the fields are empty. load

Thanks again for your great work!

pboutin commented 2 years ago

The way it work, it saves the current URL of the browser (which should change every time a new search is triggered). Make sure the URL properly updates within the browser before saving a trade.

lesse83 commented 2 years ago

Ok - the url gets updated after klicking search - for example: https://www.pathofexile.com/trade/search/sony/Kalandra/WmwDL4mSm

...if i then register the trade, afterwards double click the registered trade the last parameter of the resulting URL is stripped: https://www.pathofexile.com/trade/search/sony/Kalandra

(like said - it works for PC, but not for Playstation...)

dbjorge commented 2 years ago

Hi @lesse83,

Thanks for reporting the issue! I confirm that I can reproduce the issue you've described, I'll take a look at fixing it tonight.

dbjorge commented 2 years ago

This is fixed by https://github.com/exile-center/better-trading/commit/817525b13e8a03d3fc1257d89ca31ec17d042537 and will be included in the next version of the extension.

dbjorge commented 2 years ago

Fix released in 1.7.1.

lesse83 commented 2 years ago

Awesome - thanks a lot!