search

existentialmutt / ajax_modal_rails

ajax-driven modals for rails apps using bootstrap 4
MIT License
1 stars 2 forks source link

make modal more intuitively closable #3

Open dfhoughton opened 6 years ago

dfhoughton commented 6 years ago

I'm thinking people will expect to be able to close the modal by clicking on the grey mask layer or by pressing escape.

existentialmutt commented 6 years ago

In my experience the expected behavior can go either way. Modals used to to just display information are nice to be easily dismissable, while for forms loaded in modals you want them to be very deliberately dismissable so the user doesn't accidentally close them and lose data.

Presently the method for configuring the dismissablity of the modal is to copy the javascript into your project and make a modification. It could be nice to be able to pass optional configuration options to new AjaxModal() so feel free to submit a pull request that adds this functionality.