search

exlibris-fed / exlibris

MIT License
4 stars 0 forks source link

Add internationalization #43

Closed Sigafoos closed 4 years ago

Sigafoos commented 4 years ago

I went with vue-i18n, as it seemed like the best option. I'm fairly sure I got everything, but we should probably move everything out of views and into components (like with Home).

I have no idea how we're going to get translations for non-English languages: we'll have to rely on PRs for that.

Closes #42

Sigafoos commented 4 years ago

Whoops, forgot to commit the package.json. I’m away from my laptop but will add that in a few minutes.

Sigafoos commented 4 years ago

I’d also like to add linting (why wait for #35?): https://eslint-plugin-vue-i18n.intlify.dev/started.html#installation

Sigafoos commented 4 years ago

The eslint config has support for something like src/components/Home/locale.json, which we don't use right now. I think I'd like to eventually, but it's out of the scope of this PR.

mattgen88 commented 4 years ago

Needs conflicts resolved, but otherwise good to go. There might be a few stragglers like the image alt, but I'm not super concerned with getting it all, just that we have the ability