Open mattgen88 opened 4 years ago
I admit I'm not fully cognizant of how this is used right now, but is this variable even really necessary? It seems like there are two scenarios:
http://localhost:8081/api/
(though the port is configurable)/api/
(because it's on the same domain)You have a point, it may not be.
Currently, when building the exlibris image, VUE_APP_API_ORIGIN is used to set the api origin for the vue app, but is used as at compile time for building the static assets. This is a problem if you want to just run the application. Instead of compiling the api origin into the static assets, we need to be able to set this variable at run time.
https://medium.com/@rakhayyat/vuejs-on-docker-environment-specific-settings-daf2de660b9 may be a solution.
Then, on docker run, you can specific the VUE_APP_API_ORIGIN variable and have the vue app point to the correct API.