exo-digital-labs / ERC721R

https://erc721r.super.site/
MIT License
240 stars 60 forks source link

Do we need to have two different mintPrice? #29

Open lawweiliang opened 2 years ago

lawweiliang commented 2 years ago

Presale nft price should be lower than publicSale nft price? Right?

Business logic

Benefits

Problem with this implementation

Any clue on this?

image

elie222 commented 2 years ago

Hey,

So for a lot of projects having mint list sale and public sale at the same price makes sense. But it's up to each team to decide this. A different approach needs to be taken if the price differs. One solution is to store the mint price for each tokenId.

For CryptoFighters we do have two price ranges because v1 holders get a discounted rate on the upgrade. The example contract has more on it. I will try upload the new CF example soon. We'll probably remove it from this repo and just link to it as an example.

elie222 commented 2 years ago

Here we refund holders at different prices: https://github.com/exo-digital-labs/ERC721R/blob/main/contracts/cryptofighters/CryptoFightersV2.sol#L117