Open elie222 opened 2 years ago
@elie222 Yeah, refund event is needed.
Aside from that I think all these functions need events as well
Why?
Easy for frontend to track they are successfully call the function.
Adding these to the CF contract. Can add into the main repo after 👍
@elie222 , do you need help on this? Offer to help. 😄
We have a developer working on it in any case. The most help may be around this PR if you notice anything wrong: https://github.com/exo-digital-labs/ERC721R/pull/32
Alright, I take a look.
Status?
We used IERC721R for CryptoFighters Alliance: https://etherscan.io/address/0x06daf7e34595f9d3260dd5262dca8e3bcfeb39d5#code
Will look to move the latest code into this repo later this week.
Wonder if we add a Refund event. Probably helpful to have.
Also thinking about the interface as a whole. Perhaps something like this with Refund event:
Anything else we may want here?