exo-digital-labs / ERC721R

https://erc721r.super.site/
MIT License
240 stars 60 forks source link

Deploy to NPM #7

Open ScreamingHawk opened 2 years ago

ScreamingHawk commented 2 years ago

ERC721A is available on NPM, which makes it easy to include in projects managed with npm/yarn. https://www.npmjs.com/package/erc721a It would be awesome to see ERC721R available in this way as well.

elie222 commented 2 years ago

hey, we'd have to adjust the structure a bit to make that work but agreed.

currently it's code snippets you can add to your own project but if we turn it into a contract you inherit this would work. we need to see the best way to implement this as there are a few different forms this contract could take. with cryptofighters having two price points we had to store more info than we would have had to for a regular contract using refunds. but we'll try find a generic solution that covers many cases. or have a few different formats for erc721r that people can use

lawweiliang commented 2 years ago

@ScreamingHawk and @elie222 ,

We are definitely going to create a npm package for ERC721R. I will put it in my task list. Good suggestion.

lawweiliang commented 2 years ago

@ScreamingHawk and @elie222 ,

I had created an npm package for ERC721R. https://www.npmjs.com/package/erc721r

elie222 commented 2 years ago

Awesome. We have a PR being worked on that will help here: https://github.com/exo-digital-labs/ERC721R/pull/16

lawweiliang commented 2 years ago

Awesome. We have a PR being worked on that will help here: #16

@elie222 , you share message in wrong place. Issue here is related to NPM deployment. Not relate to any owner mint function.

I believe you are trying to share the message over issue https://github.com/exo-digital-labs/ERC721R/issues/12 😄

elie222 commented 2 years ago

It wasn't a mistake. Right now the npm package doesn't do anything as there's no contract to inherit from for your own project. But as we extract the core refund functionality into its own contract the npm package will become useful.