download progress & error messages

exo-explore / exo

Run your own AI cluster at home with everyday devices 📱💻 🖥️⌚

GNU General Public License v3.0

16.88k stars 907 forks source link

download progress & error messages #275

Open DevEmilio96 opened 2 months ago

DevEmilio96 commented 2 months ago

Hi @AlexCheema,

I wanted to inform you about two issues:

-The download progress fetch now loops infinitely even when there's no download in progress. -When there's insufficient memory to start a model, the error message is no longer being displayed.

If I can help you, please let me know.

merge : #272

AlexCheema commented 2 months ago

What's the problem with periodically fetching the download progress when it's not in progress?
Not sure what you mean by this. Do any errors show? Is this the only error that doesn't show? What do you mean by insufficient memory?

DevEmilio96 commented 2 months ago

Regarding the first point, I just wanted to inform you about the infinite loop because I thought it might be something you'd prefer to avoid, even though it's not currently causing any issues.

As for the second point, when there isn't enough memory for the model to calculate a response, exo used to display an "out of memory" error, but now that error only appears in the console and not in tinychat. I haven't checked if this issue affects other error messages as well.

Let me know if you need further details.

AlexCheema commented 2 months ago

"infinite loops" are everywhere in exo. It's completely fine and the desired behaviour. Some things we want to run periodically, there's nothing wrong with that.

Regarding the second issue, that's a good catch - do you know how to fix this? Would be a valuable contribution to handle this edge case.

DevEmilio96 commented 2 months ago

Ok, got it !
Yes I'll solve it, now I'll investigate the problem.