11.0.2 API Changes to GetAddOnMetadata and GetSpellInfo()

[LootFever]

API changes in 11.0.2 from GetAddOnMetadata to C_AddOns.GetAddOnMetadata and GetSpellInfo() to C_Spell.GetSpellInfo().

Apparrently C_Spell.GetSpellInfo() can also be replaced with C_Spell.GetSpellName(). Might be better performing since it doesn't pull the whole table. Needs to be tested.

[rursache]

@exochron can we get this merged and uploaded to curseforge? thanks

[Rmkrs]

Found a missing change while applying your MR manually to my local files.

GetSpellDescription was also changed in 11.0.2, which is used in Filters.lua:24

local spellDescription = GetSpellDescription(spellId)

Should be:

local spellDescription = C_Spell.GetSpellDescription(spellId)

Does not throw a lua exception on load, but if you open the toybox and type something in the search bar it pops-up.

[exochron]

Hello, an thank you all for your participation. I didn't expect for anyone to pitch in during my short leave. As you can see, small one man projects (like this) can go down really fast when the one maintainer is absent. So if anyone of you is interested in sticking around your more then welcome to join the crew. :smile:

[exochron]

However I'm declining this PR. Mostly because some api changes won't work like this in Classic. I am preparing a patch. So expect a fix soon :)

[Rmkrs]

To be fair, @LootFever did most/all of the work, and my reason was quite selfish, I wanted to play the new expansion with all addons turned on 😅

[LootFever]

To be fair, @rursache did most/all of the work, and my reason was quite selfish, I wanted to play the new expansion with all addons turned on 😅

damn

[Rmkrs]

To be fair, @rursache did most/all of the work, and my reason was quite selfish, I wanted to play the new expansion with all addons turned on 😅

damn

Oh haha, linked the wrong name, sowwie xD I meant you of course.

[exochron]

:hugs: