exodus4d / pathfinder

Mapping tool for EVE ONLINE
https://www.pathfinder-w.space
MIT License
385 stars 251 forks source link

[Feature Request] Add the Abbility to share the Map with more than three Chars or Corps or Alliances #222

Open Dark-Aeon opened 8 years ago

Dark-Aeon commented 8 years ago

I just tried to share a Map with an Allaince a Corp and a couple of characters. It was only Possible to share between up to 3 Corporations or only 3 Alliances or 3 Characters but its not possible to mix and match.

Beeing Able to Mix and match in Map sharing would be awesome.

IvandaNothabeer commented 8 years ago

Share limit is in the config file.

Dark-Aeon commented 8 years ago

ty for your answer :-) is the mix and match limitation between Corp/Alliance and Character also in the config file?

exodus4d commented 8 years ago

No it is not. This features is not implemented. I´m not sure If I´ll add something like this in future. It is not on top of my TODO list ;)

Dark-Aeon commented 8 years ago

ty for the Information and quick reply :-) I would love such a feature because Our Alliance wants to share the maps with some out of Alliance Corps and Characters. (Neutral alts) and adding all Corps in the Alliance plus the Out of Alliance Corps is working but then we cant add Characters in NPC coprs.

IvandaNothabeer commented 8 years ago

The issue is in the way that the "Search" feature is implemented and the way that the database splits Users, Corps, and Alliances into separate models. From my initial reading of the code, its a major job to change this.

exodus4d commented 8 years ago

No it is not hard to implement this. but it wil will take some time, but it isn´t complex.

Backend tasks: The way it should be working is, just to add some additional datatabase entries for a map in character_map, corporation_map, alliance_map. So a map could have multiple connections between multiple entity types (chars, corps, ally). After this we should ignore the "map_type" column in "maps" table, and add some additinal code in charactermodel.php#L517

Frontend tasks: Adjust the UI for map sharing options. This will also need a refactoring for some templates and javascript functions.

It is nothing I´ll implement in 2016, thats for sure :)

hilocz commented 7 years ago

I tried to share map with more that 3 corps and settings in pathfinder.ini is not honored.

[PATHFINDER.MAP.CORPORATION]
LIFETIME                    =   99999
MAX_COUNT                   =   4
MAX_SHARED                  =   5
MAX_SYSTEMS                 =   100
ACTIVITY_LOGGING            =   1

still showing max 3 corps

exodus4d commented 7 years ago

@dkrotil clear your cache after changed in pathfinder.ini were made, or wait for 1h (default cache time for map settings). I don´t have problems with the share limit. Verify the small letter below the search field should have changed: vmm123u

hilocz commented 7 years ago

Clearing the cache did the trick, it´s working now.

GhostShell77 commented 7 years ago

hi ! What about this fonctionnality now ? it will be fine to have it and share between alliance, corp or char whithout map type ! Thank you.

AmraNiYesta commented 4 years ago

But, a new patched arrived, we can share bookmarks and something is missing, I had to return on tripwire ... I am not able to add individual pilotes and i have a bad limite of who i can add to my map access list. We really need that on pathfinder, then, I think, we will have the best mapper we can find.

Ok, I notice this is a feature someone asked 3 years ago... Ok... If it is not hard, why not to do it ? It is a core feature in tripwire. Last edit : this is what made me switch back to tripwire, really sad, I started to love pathfinder.

Sjolus commented 4 years ago

I'll throw the "mix and match" stuff a good ol' +1. We run a corp map but for some situations, we'd like to offer it up to some alliances, some specific corps in some alliances, etc etc. Love Pathfinder and all that it gives us, but this is a thorn in the side every now and then 🤗