search

exodus4d / pathfinder

Mapping tool for EVE ONLINE
https://www.pathfinder-w.space
MIT License
384 stars 251 forks source link

System batch deleting #443

Open Slivo-fr opened 7 years ago

Slivo-fr commented 7 years ago

Hello,

I hosted the 1.2.0 version of pathfinder. When I add much system (100 at the moment) and I try to select them all, then delete them with a single action, some of them (about half) appears again few seconds later.

Trying to batch delete remaining systems does not works until few minutes.

MorpheusXAUT commented 7 years ago

I've had the same issue appear every once in a while, my assumption is that it's caused by AJAX/polling calls to the backend every few seconds retrieving old data while the new state (aka "systems have been bulk deleted") is still being processed. I've also had the issue that systems just randomly re-appear after deleting them (sometimes even single systems) or change their assigned name back.

Can't really say if that improved if you're using the WebSocket extension (since that should allow for faster data transmission and thus hopefully less inconsistencies) since I'm not running it due to the 100% CPU bug.

@Slivo-fr does your issue appear to happen more often if you have multiple pathfinder tabs open (e.g. with multiple chars) or when there's more people online at the same time?

Slivo-fr commented 7 years ago

I have no Idea, I tried it on a fresh new install, adding many system for custom naming, and get the issue each time i tried to delete them all (100 as explained).

I don't see how multiples tabs or user could make it better :/

MorpheusXAUT commented 7 years ago

I don't see how multiples tabs or user could make it better :/

My assumption was having multiple tabs open or several users simultaneously accessing the same map would actually make it worse, causing systems to "reappear" to "jump back" to their original names even more often.

My first, rough guess would have been that this is caused by the timing of multiple clients querying and updating the backend. My assumption is that somehow, your client fetches data from the backend at the roughly same time it wants to perform the bulk-delete, which could cause inconsistencies in data and maybe have systems reappear? On the other hand, I'm not 100% sure how pathfinder handles these causes, @exodus4d would have to comment on that.

Slivo-fr commented 7 years ago

Well, I was the only user of a fresh install with a new map.

Slivo-fr commented 7 years ago

Just happens with a small set of systems (3)

Slivo-fr commented 7 years ago

Just happened with a single connection between two wormhole

exodus4d commented 7 years ago

Just tested it with 97 systems on my local installation (just me). Could not reproduce this, but I agree this is problably a problem with "interfering" when multiple users are online.

I let this issue open, and will have an eye on this...

Slivo-fr commented 7 years ago

Let me know if I can provide some useful information to help