BadMethodCallException getOwnerKey() and getForeignKey() in Fields/Relationships/BelongsTo.php and Columns/Relationships/BelongsTo.php

[jellesimons]

Laravel version: 5.8.35 PHP version: 7.2.22 exodusanto/administrator version: 5.8.0

There is a problem with two method names inherited from Illuminate/Database/Eloquent/Relations/Relation.php

Method getOwnerKey() is named getOwnerKeyName() and method getForeignKey() is named getForeignKeyName().

In file Fields/Relationships/BelongsTo.php:

line 32: $options['foreign_key'] = $relationship->getForeignKeyName();

In File Columns/Relationships/BelongsTo.php:

• line 115: ' = ' . $last_alias . '.' . $relationship->getForeignKeyName();

• line 126: $where = $this->tablePrefix . $first_model->getTable() . '.' . $first_relationship->getForeignKeyName() .

• line 144: $fk = $nested['models'][0]->{$nested['pieces'][0]}()->getForeignKeyName();

-line 114: ' ON ' . $alias . '.' . $relationship->getOwnerKeyName() .

• line 128: $field_table . '.' . $first_relationship->getOwnerKeyName();

[jmichaelterenin]

I just upgraded to: PHP 7.2.24 Laravel version 5.8.35 exodusanto/administrator version: 5.8.0

and pages in Admin that were working for years are now broken (same error). Please respond when you have a chance. I'm not positive the solution is what the previous author outlined, but the error exists nonetheless.

[exodusanto]

Can someone share an example of model configuration?

[jmichaelterenin]

Hi exodusanto, Thank you for replying. It seems like you're not experiencing it at all? It's actually broken every page I've created. And this didn't occur when I upgraded to 5.8, it's when I upgraded to PHP 7.2.24.

I'll provide a model configuration shortly.

[exodusanto]

Thank you. I'm recently push on develop branch the update of methods name. Can you try the fix? In your composer.json add the VCS section and update the package version to dev-develop

[jmichaelterenin]

review.php:

`<?php

namespace App;

/*

• Created on Oct 1, 2014
• To change the template for this generated file go to
• Window - Preferences - PHPeclipse - PHP - Code Templates */

require_once('uploadable.class.php');

class Review extends Uploadable {

/**
 * Ardent validation rules
 */
public static $rules = [
  'reservation_id' => 'required',
  'title' => 'required',
  'score' => 'required|integer|between:1,10',
];

/**
 * The database table used by the model.
 *
 * @var string
 */
protected $table = 'reviews';

// MASS ASSIGNMENT -------------------------------------------------------
// define which attributes are mass assignable (for security)
// we only want these 2 attributes able to be filled

protected $fillable = ['reservation_id', 'title', 'blurb', 'score', 'reviewed'];

public static function boot()
{
    parent::boot();

    static::updating(function ($review) {
        // Set reviewed_on timestamp if it's being changed to 'reviewed'
        if ($review->reviewed && $review->isDirty(['reviewed'])) {
            $review->reviewed_on = date('Y-m-d H:i:s');
        }
    });
}

public function reservation()
{
    return $this->belongsTo('App\reservation');
}

} ` reviews.php:

`<?php /*

• Created on Oct 1, 2014
• To change the template for this generated file go to

• Window - Preferences - PHPeclipse - PHP - Code Templates */

  return array(

  /**

  • Model title
  • @type string */ 'title' => 'Reviews',

  /**

  • The singular name of your model
  • @type string */ 'single' => 'Hotel Review',

  /**

  • The class name of the Eloquent model that this config represents
  • @type string */ 'model' => '\App\review',

  /**

  • The columns array
  • @type array */ 'columns' => array( 'facility' => array( 'title' => 'Facility', 'relationship' => 'reservation.facility.entity', 'select' => '(:table).name', ), 'user' => array( 'title' => 'Reviewer', 'relationship' => 'reservation.user', 'select' => '(:table).email', ), 'title' => array( 'title' => 'Title', ), 'score' => array( 'title' => 'Score',
    ), 'submitted_on' => array( 'title' => 'Review Timestamp', ), 'reviewed' => array( 'title' => 'Reviewed?', 'select' => "IF((:table).reviewed, 'yes', 'no')",
    ), 'reviewed_on' => array( 'title' => 'Reviewed on',
    ),
    ), 'edit_fields' => array( 'reservation' => array( 'title' => 'Reservation', 'type' => 'relationship', 'name_field' => 'title',
    ),
    'title' => array( 'title' => 'Title', 'limit' => 40,
    ), 'blurb' => array( 'title' => 'Review', 'type' => 'textarea', 'limit' => 400,
    ), 'score' => array( 'title' => 'Score (1-10)', 'type' => 'number',
    ),
    'reviewed' => array( 'title' => 'Reviewed?', 'type' => 'bool', ),
    ),

  'filters' => array( 'reviewed' => array( 'title' => 'Reviewed?', 'type' => 'bool',
  ),
  ),

  /**

  • The query filter option lets you modify the query parameters before Administrator begins to construct the query. For example, if you want
  • to have one page show only deleted items and another page show all of the items that aren't deleted, you can use the query filter to do
  • that.
  • @type closure */ 'query_filter'=> function($query) { if (!Auth::user()->hasRole('Admin') && Auth::user()->hasRole('Provider')) { // $user = Auth::user(); // $query->join('services', 'service_locations.service_id', '=', 'services.id') // ->join('providers', 'services.provider_id', '=', 'providers.id') // ->where('providers.admin_id', '=', $user->id); } },

  'permission'=> function() { $admin_exists = \App\Roleuser::where('role_id', '=', 1)->first(); if ( !is_null($admin_exists) ) { return (Auth::check() && (Auth::user()->hasRole('Admin') || Auth::user()->hasRole('Provider'))); } else { return true; } },

  'action_permissions'=> array( 'create' => function($model) { return true; }, 'delete' => function($model) { return true; }, 'update' => function($model) { return true; }, ),

  'sort' => array( 'field' => 'created_at', 'direction' => 'desc', ),

  )

?> `

[jmichaelterenin]

Yes, that version is working as expected. Thank you for the fix. Let me know when it's committed.

[exodusanto]

Fixed in version 5.8.1