exoframejs / exoframe

Exoframe is a self-hosted tool that allows simple one-command deployments using Docker
https://exoframejs.github.io/exoframe/
1.13k stars 56 forks source link

Migrate from Travis-CI to Github Actions #283

Closed yamalight closed 4 years ago

yamalight commented 4 years ago

Initial work for server has been done in https://github.com/exoframejs/exoframe-server/pull/33 (huge thanks to @anbraten).

Things to do:

anbraten commented 4 years ago

Github actions seems to work quite well with a monorepo:

on:
  push:
    branch: develop
    paths:
      - 'packages/cli/**'

As the issues and documentation are already inside this main repo, I think adding the server and maybe later the other packages sounds quite handy to me.

yamalight commented 4 years ago

@anbraten wouldn't those actions run on every commit though? Or does github handles executions in "smart" way only when something's changed? 🤔

anbraten commented 4 years ago

on -> paths is a quite nifty feature by github. It checks if a push has changed a file inside its defined path-pattern. Docs

We could simply write separate workflows for the cli, server packages.

yamalight commented 4 years ago

@anbraten oooh, that's pretty awesome! thanks for bringing that to my attention. that makes mono-repo quite compelling actually 🤔

yamalight commented 4 years ago

This needs to happen faster because after latest update Travis started randomly breaking builds for no apparent reason, which is pretty infuriating to fix 🤦‍♂️ Gotta find few hours to address this..

FDiskas commented 4 years ago

Please update issue what else should be done. Looks like pull request https://github.com/exoframejs/exoframe-server/pull/37 was merged and coverage is fixed already

yamalight commented 4 years ago

@FDiskas just two small tasks left - change readme badges & add coveralls to all exoframe-server test executions (currently only runs on release)

FDiskas commented 4 years ago

This ticket should go to server repo?

yamalight commented 4 years ago

@FDiskas server repo doesn't have issues, all of them are tracked here

yamalight commented 4 years ago

This is now done.