Default ignores/.exoframeignore doesn't work on Windows

exoframejs / exoframe

Exoframe is a self-hosted tool that allows simple one-command deployments using Docker

https://exoframejs.github.io/exoframe/

1.13k stars 56 forks source link

Default ignores/.exoframeignore doesn't work on Windows #284

Closed HTLFabian closed 4 years ago

HTLFabian commented 4 years ago

I was wondering why the deployment process always takes so long, and then I found out node_modules wasn't excluded. I tracked down where the issue resides, and here is the cause: https://github.com/exoframejs/exoframe/blob/0e4feb77955217625a9a65dde70bcfc880791d2b/src/commands/deploy.js#L186 It only replaces the workdir followed by a /, but on Windows it won't do anything because of the best feature Windows has to offer (\ in the path).

yamalight commented 4 years ago

@HTLFabian right, I guess it'd be better to use path package for that stuff to make it cross-platform 🤔 I'll look into it once I have some free time. PR is very welcome :)

yamalight commented 4 years ago

Ready for release in the next update thanks to @FDiskas