exogen / graphql-markdown

The easiest way to document your GraphQL schema.
MIT License
178 stars 54 forks source link

Replace reference to deprecated introspectionQuery #65

Closed aisapatino closed 3 years ago

aisapatino commented 3 years ago

Replace graphql.introspectionQuery with graphql.getIntrospectionQuery()

introspectionQuery constant was deprecated in favor of getIntrospectionQuery in v0.12.0 of graphql, and eventually removed in v15.

With this change I'm able to continue generating docs for a project that's just upgraded to v15 of graphql.

exogen commented 3 years ago

LGTM! At some point I'll want to bump the version of graphql specified in dependencies as well, and maybe also move that to peerDependencies. All good for now though since it works on v14 too.

exogen commented 3 years ago

To be safe I think I'll need to do a MAJOR bump in case someone was using it with a pre-v0.12.0 version that didn't have getIntrospectionQuery. And since it'll be MAJOR I might as well switch the dep to a peerDep now since that'd also be a breaking change. Expect a new release in a bit.

aisapatino commented 3 years ago

Sounds good, thank you!

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 77.429% when pulling f67c0500e949f3e069dbeb037acb8e7d759fbc2d on aisapatino:get-introspection-query into a543fd8eac9c44f2f865e7abb9fca215dfa50756 on exogen:master.