search

exokitxr / exokit-frontend

Frontend for exokit. Turns exokit into a spatial web browser. 🦎
7 stars 3 forks source link

Send mouse movements to html #34

Closed chrislatorres closed 5 years ago

chrislatorres commented 5 years ago

This PR fixes sending mouse movements only when orbit controls present.

Closes #26

avaer commented 5 years ago

Do we actually want to do that though? If we send the events while dragging we will be both dragging exokit and highlighting the page at the same time...

chrislatorres commented 5 years ago

The drag is only at the very top/edge of console, where text could not be highlighted.

avaer commented 5 years ago

But this code applies to all drags, no? So doing an orbit will highlight things on the page depending on how we move around.

chrislatorres commented 5 years ago

This code only applies when the target is the UI: https://github.com/exokitxr/studio/blob/8be765b5611e79ac98a7fdc0c1cbad97e5ba840b/index.html#L1219

avaer commented 5 years ago

ui seems to only mean "not locked into XR mode" -- I might be mistaken but it seems this this dragging would still happen on orbiting.

chrislatorres commented 5 years ago

note from discord:

we shouldn't be sending extra HTML events while we do exokit operations I can totally see the HTML having more complex handlers later and then dragging exokit will lag things despite having nothing to do with the HTML