search

exokitxr / exokit-web

Exokit WebXR engine for the browser
70 stars 18 forks source link

Grid depth bug #29

Closed chrislatorres closed 5 years ago

chrislatorres commented 5 years ago

The grid in app.html is displaying over loaded sites, even though their positioned above the grid.

Screenshots

depthCapture tcsitesCapture

avaer commented 5 years ago

Looks like there is some clipping though right? So the depth buffer works but isn't matching?

chrislatorres commented 5 years ago

Yes there is clipping, maybe it is due to the transparency of the grid:

apaintexowebgif7

chrislatorres commented 5 years ago

it might be the grid's transparency and in the OP, the world was actually under the grid.

avaer commented 5 years ago

That could be because our top-level THREE scene isn't using the same XR camera parameters.

How do different child RT sites interact with each other?

avaer commented 5 years ago

Might be fixed by https://github.com/exokitxr/exokit-web/pull/30/files.

avaer commented 5 years ago

Hm, I see, every site can set its own depthNear/depthFar. This applies to both WebVR and WebXR.

We'll need to check each particular case of this bug and https://github.com/exokitxr/exokit-web/pull/30 is probably insufficient.

avaer commented 5 years ago

As far as I can tell this works fine now. Is there still a reproduction case?

avaer commented 5 years ago

Wasn't able to reproduce this recently, so closing.