search

exokitxr / exokit-web

Exokit WebXR engine for the browser
70 stars 18 forks source link

SharedArrayBuffer -> ArrayBuffer #47

Closed avaer closed 5 years ago

avaer commented 5 years ago

It turns out due to how we construct the initial seed message for child windows, we can pass the SharedArrayBuffer containing the XRState by direct reference. This means it can be a pure ArrayBuffer.

Making the switch removes all reference of SharedArrayBuffer in the codebase so it should work in environments that blocked SharedArrayBuffer.

Fixes https://github.com/exokitxr/exokit-web/issues/43.

chrislatorres commented 5 years ago

Still getting errors on MLO from SharedArrayBuffer at:

https://github.com/exokitxr/exokit-web/blob/6fb22e1049fcf34746195c3c1cecd320ab3f491a/src/XR.js#L599

mlsdkchr

avaer commented 5 years ago

Thanks, good catch!

avaer commented 5 years ago

https://github.com/exokitxr/exokit-web/commit/f31ce00d3c425fa554b53df789323b7dc810b71f