exokitxr / exokit

Native VR/AR/XR engine for JavaScript 🦖
MIT License
990 stars 119 forks source link

Add Oculus support #146

Open dmarcos opened 6 years ago

dmarcos commented 6 years ago

I also tried Oculus over Steam VR. Running exokit.sh -h and pressing ctrl-1 to enter VR mode results in a crash.

avaer commented 6 years ago

Are you able to post the log when you perform the above steps? (console output of the command)

Steam VR is the one that theoretically should work.

dmarcos commented 6 years ago

This is the error I get when launching node index.js -h after pressing ctrl-1 and Oculus Rift present via SteamVR.

Error: Compositor error: VRCompositorError_TextureUsesUnsupportedFormat
    at _blit (C:\exokit\index.js:701:39)
    at Timeout._recurse [as _onTimeout] (C:\exokit\index.js:1151:5)
    at ontimeout (timers.js:427:11)
    at tryOnTimeout (timers.js:289:5)
    at listOnTimeout (timers.js:252:5)
    at Timer.processTimers (timers.js:212:10)
Bugsnag:  Encountered an uncaught error, terminating…
Error: Compositor error: VRCompositorError_TextureUsesUnsupportedFormat
    at _blit (C:\exokit\index.js:701:39)
    at Timeout._recurse [as _onTimeout] (C:\exokit\index.js:1151:5)
    at ontimeout (timers.js:427:11)
    at tryOnTimeout (timers.js:289:5)
    at listOnTimeout (timers.js:252:5)
    at Timer.processTimers (timers.js:212:10)
avaer commented 6 years ago

Thanks, this looks like the format of the texture is one oculus binding doesn't like. Needs some research.

avaer commented 6 years ago

Would be curious if the OpenVR example works in Oculus SteamVR, because that's pretty much what Exokit is doing.

avaer commented 5 years ago

Work on this issue might have conflicts with https://github.com/webmixedreality/exokit/pull/286.

dmarcos commented 5 years ago

Thanks for letting me know. I'm planning to get back to this after next week.

etiennepinchon commented 5 years ago

Same issue.

shawwn commented 5 years ago

I’m getting this too.

avaer commented 5 years ago

@dmarcos Is there a starting base for Oculus/libOVR bindings? I think @cmdrflexo wanted to dive in.

ngokevin commented 5 years ago

Not sure if he had too much, at least not NAN bindings. I think flexo could start. I was gonna start on the mobile SDK.

sidequestlegend commented 5 years ago

Just to throw in my two cents here, I have been able to use it on oculus through steam many times.

I usually start like this in the exokit folder:

Exokit version 0.0.482 - installed via git clone and npm install.

node . https://aframe.io/a-painter/

avaer commented 5 years ago

Is there any performance hit or gotchas when doing so? I'm glad it works either way, was a pleasant surprise to hear.

sidequestlegend commented 5 years ago

Not that i'm aware of, it just works. I actually used it quite a while ago around version 0.0.420 :smirk: and it worked just as well. Only issue i have was the movement-controls component had its axis' reversed but i don't think that was anything to do with exokit as it was already reported on their issue tracker.

Maybe we should all list the kit we have in a sticky location so we know what everyone has to test with.

ngokevin commented 5 years ago

Cool! Still will want native support, especially as headsets go standalone. I think there'd be some perf issues (we saw on WMR + Steam), perhaps as the app scales. Like does ATW work?

avaer commented 5 years ago

Agree, should aim for native on all desired platforms. I'm guessing there's no other option for Santa Cruz/Quest anyway.

Quest is Android though, so I'm not sure how much the binding would be Android vs how much OVR.

sidequestlegend commented 5 years ago

I'm not sure on the ATW, how do i check that?

ZNixian commented 5 years ago

Hi, I'm planning to start work on adding a native LibOVR binding. Just checking if anyone else has started work on this?

avaer commented 5 years ago

Would be much appreciated!

I don't think @dmarcos got very far, though there is a binary module at https://www.npmjs.com/package/native-oculus-deps

avaer commented 5 years ago

@dmarcos related to this, would you mind sharing collaborator status on npm/native-oculus-deps with @kazmer?

dmarcos commented 5 years ago

Done

avaer commented 5 years ago

Thanks!

On Thu, Jan 3, 2019 at 9:19 AM Diego Marcos notifications@github.com wrote:

Done

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/webmixedreality/exokit/issues/146#issuecomment-451155823, or mute the thread https://github.com/notifications/unsubscribe-auth/AGmu6RWbJPKXA0HOvf6Ojmt4u4gPaYSqks5u_hFegaJpZM4U-qC5 .