Reality Tabs in 2d broken by recent PR for XR device support in aframe.

exokitxr / exokit

Native VR/AR/XR engine for JavaScript 🦖

MIT License

996 stars 117 forks source link

Reality Tabs in 2d broken by recent PR for XR device support in aframe. #703

Open sidequestlegend opened 5 years ago

sidequestlegend commented 5 years ago

So it looks like the #695 PR breaks reality tabs in 2D mode. When running in 2D with the -x none flag i get a black screen even with the realitytabs.html example. It also doesnt seem to log the output from the tabs iframe either.

Related: #635

Repro: node . -x none https://raw.githack.com/webmixedreality/exokit/master/examples/realitytabs.html

I found that if i revert this line it works again https://github.com/webmixedreality/exokit/blob/f920e928040b5f102d5863d8bf1fc787cac9f815/src/XR.js#L34

avaer commented 5 years ago

What reality tabs 2D mode are we referring to?

sidequestlegend commented 5 years ago

this would be using the fakeVRDisplay basically

avaer commented 5 years ago

That’s not an api in exokit, it’s just some code in realitytabs.html.

But I suspect this is due to the priorities with which the displays are returned in that example.

On Sun, Jan 6, 2019 at 9:48 AM Shane Harris notifications@github.com wrote:

this would be using the fakeVRDisplay basically

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/webmixedreality/exokit/issues/703#issuecomment-451747188, or mute the thread https://github.com/notifications/unsubscribe-auth/AGmu6X74jQYPDLcP3XYvCyw0HX80jCVVks5vAgzIgaJpZM4ZybCP .