search

exokitxr / webmr-docs

Exokit documentation
https://docs.webmr.io
4 stars 2 forks source link

Doc links in the footer work from the titlepage, but DO NOT work inside the docs pages. #9

Closed ChristopherTrimboli closed 6 years ago

ChristopherTrimboli commented 6 years ago

This is a relative URL problem. They have a complicated URL linking system and this broke. Just needs some bug fixing and testing to figure this one out.

The /en folder needs to be taken out of the URL when you are inside the Docs folder.

Just documenting this but i'll prob get to it soon :)

avaer commented 6 years ago

Does this have to do with link rewriting from internationalization support?

ChristopherTrimboli commented 6 years ago

They have a system for passing the Docs requests through a language translation JSON file. That is the /en thing. First time i've seen this but yes something to do with link rewriting.

avaer commented 6 years ago

Per discussion probably just wanna trace the footer language prop upwards to see why it is or is not provided.

Because that’s what seems to construct errant urls.

On Tue, Jul 17, 2018 at 2:46 PM Chris Eddy notifications@github.com wrote:

They have a system for passing the Docs requests through a language translation JSON file. That is the /en thing. First time i've seen this but yes something to do with link rewriting.

— You are receiving this because you were assigned.

Reply to this email directly, view it on GitHub https://github.com/webmixedreality/webmr-docs2/issues/9#issuecomment-405687357, or mute the thread https://github.com/notifications/unsubscribe-auth/AGmu6b4BTf_1ketTaN-7ZllIH_wzrVkXks5uHjDygaJpZM4VTVgD .

ChristopherTrimboli commented 6 years ago

fixed