Open ernewton opened 1 year ago
Hi @ernewton — I believe that the docs and the tutorial are both correct in this case. r_pl
has units of Solar radii, and when we call get_light_curve
, we use:
light_curves = (
star.get_light_curve(orbit=orbit, r=r_pl, t=x[mask], texp=texp)
* 1e3
)
where all the arguments have the units consistent with the docs. Can you clarify what the issue is that you're seeing?
Note that when we call r_pl = pm.Deterministic("r_pl", ror * r_star)
we're converting ror
from relative units to r_pl
in units of Solar radii!
This case study has: "r_pl = pm.Deterministic("r_pl", ror * r_star)" for calculating the planetary radius. According to the documentation for get_light_curve, r_pl is in units of solar radii, not the host star radius. However, this example gets ror from get_ror_from_approx_transit_depth, for which the documentation says ror is the radius ratio and is not explicit about units. I suggest clarifying in both the case study tutorial and in the documentation about the units.