search

exoplanet-dev / exoplanet

Fast & scalable MCMC for all your exoplanet needs!
https://docs.exoplanet.codes
MIT License
206 stars 52 forks source link

Failed Test: test_full_adapt_sampling #106

Closed nascarsdale closed 4 years ago

nascarsdale commented 4 years ago

Hi exoplanet team,

Thanks for putting together this great tool! I am writing because I have run the tests, per the installation instructions, and failed the "test_adapt_full_sampling" (screenshot attached) for reasons that I could not discern.

image

I have no experience using pymc3, and the root error is " AttributeError: 'WindowedDualAverageAdaptation' object has no attribute '_mu' " which I was not sure how to handle. Have any of you seen anything like this before?

I am on exoplanet 0.3.3(.dev34+ge036bc0) (installed with pip), pymc3 3.9.2, and fastprogress 0.2.3 (the other package with an error returned in the chain). My laptop is running ubuntu 18.04.

Thank you! -Nicholas

dfm commented 4 years ago

Thanks for reporting! I'll look into this.

dfm commented 4 years ago

Hilariously it looks like I introduced this regression in a pull request to PyMC3 (PyMC3 has the correct behavior now, but I was depending on the previous, incorrect, behavior here...): https://github.com/pymc-devs/pymc3/pull/3941

dfm commented 4 years ago

This has been fixed on the main branch. Thanks again!