search

exoplanet-dev / exoplanet

Fast & scalable MCMC for all your exoplanet needs!
https://docs.exoplanet.codes
MIT License
206 stars 52 forks source link

New relativity PR #133

Closed dfm closed 3 years ago

dfm commented 3 years ago

@arjunsavel: I totally botched your version of the PR (#98) so here's a new one that will still give you the commit credit!

dfm commented 3 years ago

@arjunsavel: this is good to go now, I'm not worried (wrt this PR) about the failing tests with PyMC3 master. Let me know if you're happy for me to merge and I will! Sorry again about being slow and botching your branch.

arjunsavel commented 3 years ago

@dfm this looks great to me — and thanks so much for helping with the merge!

dfm commented 3 years ago

🚀 And we're merged. Thanks again @arjunsavel!

In the near future (before the 0.5 release) I'm hoping to refactor https://github.com/dfm/rebound-pymc3 a bit and move all of this over there, but for now I'm going to make a new exoplanet release that has this support available.