search

exoplanet-dev / jaxoplanet

Astronomical time series analysis with JAX
https://jax.exoplanet.codes
MIT License
41 stars 12 forks source link

Minor starry fixes #156

Closed soichiro-hattori closed 9 months ago

soichiro-hattori commented 9 months ago

This PR fixes some minor bugs and docs issues in the starry module.

  1. Update doc for inc argument in Map class to mention that it's initialized at 90 degrees (not 0) and that the angle is measured relative to the line of sight.
  2. Add self.normalize=normalize in Map initialization so that it's string representation isn't None.
  3. Fix doc mentions of relative in Ylm since we call it normalize.
  4. In Map initialization, when in normalize=True block, cast y[(0,0)] to float as it's otherwise a JAX ArrayImpl that doesn't show the value in the string representation.
soichiro-hattori commented 9 months ago

Now with changes that fix #157. @lgrcia I've removed normalize as an Ylm initialization argument and added a .normalize() method that returns a new Ylm instance with the normalized coefficients.