Currently, a Ylm(*, normalize=False) instance passed to the y argument of a default initialization of a Map instance is automatically normalized due to the default setting of Mapnormalize=None (which then turns to normalize=True).
y = Ylm(normalize=False)
smap = Map(y=y) # default is normalize=None which becomes normalize=True
smap
You can prevent normalization by passing normalize=False to the Map initialization but that seems a bit redundant.
I'd propose
Setting normalize=False in the default setting for the Map initialization, or
Explicitly letting the user know the passed Ylm object will be normalized, or
Removing the normalize argument in Ylm.
I could see how you might want to support normalization in both of these objects, but I think it's better if we don't override a user specification by default!
That's a bit inconsistent, you're right @soichiro-hattori. I think removing the normalize attribute from Ylm would be the right approach. I would add a normalized method in case that's useful.
Currently, a
Ylm(*, normalize=False)
instance passed to they
argument of a default initialization of aMap
instance is automatically normalized due to the default setting ofMap
normalize=None
(which then turns tonormalize=True
).Output (after merging #156):
You can prevent normalization by passing
normalize=False
to theMap
initialization but that seems a bit redundant.I'd propose
normalize=False
in the default setting for theMap
initialization, orYlm
object will be normalized, ornormalize
argument inYlm
.I could see how you might want to support normalization in both of these objects, but I think it's better if we don't override a user specification by default!
@dfm, @lgrcia