Open shashankdholakia opened 8 months ago
Thanks for asking! The plan is to eventually deprecate the limb_dark.light_curve()
function once all the starry
/Surface
stuff gets moved out of experimental
. For now, none of the orbits within core support surface maps, so the only way to use those are via the limb_dark
interface.
At the end we kept the limb darkened case separated from the fully non uniform case. As you suggest, surfaces are ignored when using jaxoplanet.light_curves.limb_dark. Do you think a warning would help?
Previously, the limb darkened light curve (similar to
exoplanet
's syntax) could be passed in a KeplerianOrbit, without instantiating aCentral
object orBody
object (which is more similar tostarry
's syntax). Is this still possible with the current version of jaxoplanet? I see that a System can be passed tolimb_dark.light_curve()
, but in this case I assume anySurface
s are ignored in favor of the limb darkening parameters passed to the function, which feels a bit awkward.