exoplanet-dev / jaxoplanet

Astronomical time series analysis with JAX
https://jax.exoplanet.codes
MIT License
41 stars 12 forks source link

Passing Keplerian orbital parameters to limb_dark.light_curve() #174

Open shashankdholakia opened 8 months ago

shashankdholakia commented 8 months ago

Previously, the limb darkened light curve (similar to exoplanet's syntax) could be passed in a KeplerianOrbit, without instantiating a Central object or Body object (which is more similar to starry's syntax). Is this still possible with the current version of jaxoplanet? I see that a System can be passed to limb_dark.light_curve(), but in this case I assume any Surfaces are ignored in favor of the limb darkening parameters passed to the function, which feels a bit awkward.

dfm commented 8 months ago

Thanks for asking! The plan is to eventually deprecate the limb_dark.light_curve() function once all the starry/Surface stuff gets moved out of experimental. For now, none of the orbits within core support surface maps, so the only way to use those are via the limb_dark interface.

lgrcia commented 1 month ago

At the end we kept the limb darkened case separated from the fully non uniform case. As you suggest, surfaces are ignored when using jaxoplanet.light_curves.limb_dark. Do you think a warning would help?