search

exoplatform / app-center

**Deprecated** Add-on to manage external applications
https://github.com/Meeds-io/app-center
GNU Lesser General Public License v3.0
0 stars 1 forks source link

Fix issue #2 feedbacks #3

Closed azayati closed 4 years ago

azayati commented 4 years ago

This PR fixes:

@vsellier

  • changelog-1.0.0.xml
  • The tables should be prefixed by something like AC_ or few letters allowing to identify them
  • https://github.com/exo-addons/app-center/blob/master/app-center- services/src/main/resources/db.changelogs/changelog-1.0.0.xml#L48 why 250 the usual size is 200
  • Inconsistency between the namedquery getAppByNameOrTitle and it's parameters

@thomasdelhomenie

  • The size of the URL field in the database is too short, URLs can be longer then 250 characters. (Set to 500)
  • Using "like '%...%'" in named queries on permissions can cause issues IMO, for example if several groups have the same beginning (/group1 and /group10)
  • IMO we should not retrieve the groups of the user in the DAO, but instead pass the list of the groups to the DAO and build a query with this list of groups.