search

exoplatform / chat-application

Chat application
GNU Affero General Public License v3.0
38 stars 57 forks source link

fix: Fix Display issue where chat room messages are no longer displayed - EXO-68593 #695

Closed IlhemEssaadi closed 6 months ago

IlhemEssaadi commented 6 months ago

Prior to this change, there was a problem when attempting to parse a long from an empty toTimestamp string, as StringUtils.isNumeric(toTimestamp) returned true for an empty string, resulting in a NumberFormatException. This commit solves the problem by updating the import instruction to use org.apache.commons.lang3.StringUtils instead of org.apache.commons.lang.StringUtils. StringUtils.isNumeric now correctly checks that an empty string is not numeric, preventing long parsing attempts.

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

rdenarie commented 6 months ago

@IlhemEssaadi In your commit message you explain HOW you fix the problem, but you dont explain WHAT is the problem. Can you add something to explain this point ? Thanks

IlhemEssaadi commented 6 months ago

@IlhemEssaadi In your commit message you explain HOW you fix the problem, but you dont explain WHAT is the problem. Can you add something to explain this point ? Thanks

Done!!