exorde-labs / exorde-client

Exorde participation module (Testnet 2022-2023) - CLI
GNU General Public License v3.0
1.11k stars 84 forks source link

Fix codestyle a little in Launcher.py #4

Closed OlegYurchik closed 1 year ago

OlegYurchik commented 1 year ago

Just trying fix a codestyle a little. If it is a OK, I can refactoring python modules and add linting (pylint or mypy) in CI/CD

jean-baptiste-exorde commented 1 year ago

Hi OlegYurchik, thank you for your interest in the participation module. We are currently doing a full rewrite from scratch of the participation module, with better coding practices (real use of git versioning, tests, stronger CI/CD chain, etc.).

It's not worth putting a lot of effort into trying to improve the current version.

I'll try to merge this PR, hope it doesn't get overwritten.

OlegYurchik commented 1 year ago

@jean-baptiste-exorde Can I participate to develop new exorde module cli from scratch?

MathiasExorde commented 1 year ago

Hi Oleg Yurchik,

We appreciate your will to contribute so much! Thanks so much already.

As you seen, the code is basic because we are already re developing a new module from scratch. We hired a dedicated engineer, redoing it all with async http io, no threads, with a Web-based UI/UX.

Maybe we can find other things to improve in the short/medium term? There is a lot to do around the module & protocol perhaps.


From: Oleg Yurchik @.> Sent: Monday, November 21, 2022 8:45:27 PM To: exorde-labs/ExordeModuleCLI @.> Cc: Mathias Dail @.>; State change @.> Subject: Re: [exorde-labs/ExordeModuleCLI] Fix codestyle a little in Launcher.py (PR #4)

@jean-baptiste-exordehttps://github.com/jean-baptiste-exorde Can I participate to develop new exorde module cli from scratch?

— Reply to this email directly, view it on GitHubhttps://github.com/exorde-labs/ExordeModuleCLI/pull/4#issuecomment-1322562452, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWIOR2ZHX4F24YSGBQRIMSDWJPGNPANCNFSM6AAAAAASFH25AM. You are receiving this because you modified the open/close state.Message ID: @.***>

OlegYurchik commented 1 year ago

@MathiasExorde Thank you! I have a experience with asyncio and aiohttp, FastAPI, async interaction with different databases. I offer my help in any of your open source projects. I will glad to work with Exorde and do any short/medium term tasks

MathiasExorde commented 1 year ago

We have a Community bounty system, to allocate future EXD token to open source tasks. You could be the first one :)

Something very interesting we need is more "scrapers" to be integrated in the architecture: an HTML-based Reddit scraper (no API). A Bitcointalk scraper, etc. Would you like to contribute to this?

OlegYurchik commented 1 year ago

@MathiasExorde Sure, it is very interesting for me! Where I can see this tasks?

MathiasExorde commented 1 year ago

We can setup something!

MathiasExorde commented 1 year ago

@OlegYurchik We will setup a proper page, with more doc/tests, but it might take a while. So if you want to start contributing now, here is the outline of the task:

Data collection Task A: Moderate difficulty Goal: Scrape the forum "Bitcoin Talk" https://bitcointalk.org/ Requirements:

Data collection Task B: Higher difficulty/importance, higher rewards Goal: Scrape Reddit Requirements:

Note:

Does that seem OK? :)

Thanks

Mathias Dail CTO @ Exorde Labs

MathiasExorde commented 1 year ago

You can also join Discord, to discuss in open-source-dev-bounties: https://discord.com/channels/754992505241469040/1045041608887914507