exoscale / cert-manager-webhook-exoscale

A cert-manager webhook for creating an ACME DNS01 solver webhook for Exoscale

Apache License 2.0

3 stars 3 forks source link

fix(deployment): Update the default webhook docker image to an existing image. #10

Closed mlec1 closed 9 months ago

mlec1 commented 11 months ago

Description

Update the default image tag of the webhook docker image because the dev tag doesn't exist on dockerhub. I know this can be customized in the kuztomise.yaml file, but I think it might be nice to be able to deploy it as it is.

I chose the tag latest to have the same default value as the helm deployment.

Checklist

(For exoscale contributors)

[ ] Changelog updated (under Unreleased block)
[ ] Integration testing

Testing

jessicatoscani commented 11 months ago

Hello @mlec1, Thanks for your contribution. The manifest is generated with helm command, It must be fixed there as well or your changes will be lost at the next update.

mlec1 commented 10 months ago

@jessicatoscani I set the image tag to "latest" in the Makefile. If I take more times, I might open an MR one day to automate the deployment.