search

exoscale / cs

A simple, yet powerful CloudStack API client for python and the command-line.
BSD 3-Clause "New" or "Revised" License
88 stars 36 forks source link

config: accept verify=False #80

Closed greut closed 5 years ago

greut commented 5 years ago

This allows such configuration, which is mostly useful for special developer cases.

endpoint = https://192.168.1.1/compute
dangerous_no_tls_verify = false

http://docs.python-requests.org/en/master/user/advanced/?#ssl-cert-verification

brutasse commented 5 years ago

I've tried to avoid adding such a possibility in the past, e.g. https://github.com/exoscale/cs/pull/18 and https://github.com/exoscale/cs/pull/27

The reasoning is that an insecure setup should be either hard to get or it should be obvious that it's insecure. If there really is no other way I'd love something in the spirit of hdparm's --yes-i-know-what-i-am-doing and --please-destroy-my-drive flags, i.e. something more glaring than verify=False.

greut commented 5 years ago

@brutasse requests comes with its own set of warnings once false is set.

greut commented 5 years ago

@brutasse verify = false still does nothing useful, but dangerous_no_tls_verify = true does.