search

exoscale / egoscale

exoscale golang bindings
https://pkg.go.dev/github.com/exoscale/egoscale/v3
Apache License 2.0
31 stars 15 forks source link

fix: incomplete package retraction #626

Closed ldez closed 3 months ago

ldez commented 3 months ago

Description

Fixes #586

After the merge of this PR, you should create a tag v1.19.1 as explained here.

To retract a version, a module author should add a retract directive to go.mod, then publish a new version containing that directive. The new version must be higher than other release or pre-release versions; that is, the @latest version query should resolve to the new version before retractions are considered.

Related to https://github.com/exoscale/egoscale/issues/482 Related to https://github.com/exoscale/egoscale/issues/483

ldez commented 3 months ago

Friendly ping to @pierre-emmanuelJ

pierre-emmanuelJ commented 3 months ago

Thanks a lot for these changes, I will take a care look on it :) to make the retraction

ldez commented 3 months ago

The main element is to create a tag v1.19.1 after the merge of the PR.

To retract a major version, you should retract 2 versions: the problematic version and the next one (this one should be higher than the previous one). The Go documentation is not super clear but this is the expected workflow.