exoscoriae / eXoDOS

eXoDOS
69 stars 3 forks source link

Language Packs - central install.bat syntax issue #5054

Closed TimberlAndRE-de closed 3 months ago

TimberlAndRE-de commented 6 months ago

@boohyaka found a bug in the /eXo/util/!languagepacks/install.bat (base pack v6)

grafik

don't know where this -d comes from but it's not a del parameter. del is actually skipping it altogether, but will actually parse and try to delete the other paths in the string

grafik

fix is pretty easy. just need to remove everything starting and including -d in the batch it should look like this: del ".\eXoDOS\%languagefolder%\!save\%GameName%.zip"

steps to reproduce the bug:

although it only affects the langauge packs (base pack is fine), the central install.bat for the language packs is part of the base pack, so a base pack fix is needed.

exoscoriae commented 3 months ago

i don't believe I wrote this file, did I?

The -d is clearly left over from someone copying a line with the unzip utility.

exoscoriae commented 3 months ago

fix applied