search

expandedfronts / revisr

Revisr: Git for WordPress
https://revisr.io
GNU General Public License v3.0
195 stars 41 forks source link

Anonymous function in class-revisr-commits throws error #46

Closed jimwebb closed 9 years ago

jimwebb commented 9 years ago

Using PHP 5.2 with Revisr 1.9.3 on WP 4.1.1, the following fatal error is returned:

Parse error: syntax error, unexpected T_FUNCTION in /home/graffiatodc/webapps/mic_wp/wp-content/plugins/revisr/includes/class-revisr-commits.php on line 113

There's an anonymous function there, which is functionality that's only available in PHP 5.3 or newer. Bummer.

Using create_function() is a possibility, but it's a little bit icky, right? Could this particular instance be converted to a named function? Sorry.

mattgrshaw commented 9 years ago

Thanks, didn't catch this since PHP Unit requires 5.3+.

mattgrshaw commented 9 years ago

Hi Jim, this should be fixed with 1.9.4. Thanks again!

jimwebb commented 9 years ago

Thanks, Matt! That's awesome!

On Mon, Apr 6, 2015 at 7:19 PM, Matt Shaw notifications@github.com wrote:

Hi Jim, this should be fixed with 1.9.4. Thanks again!

Reply to this email directly or view it on GitHub https://github.com/ExpandedFronts/Revisr/issues/46#issuecomment-90281273 .