expandorg / worker-app

worker application
https://portal.expand.org/
Mozilla Public License 2.0
2 stars 0 forks source link

Video tag component with initial value can have time set to NA by dragging timeline #185

Closed kieranoreilly closed 5 years ago

kieranoreilly commented 5 years ago

img

{"modules": [{"src": "https://www.youtube.com/watch?v=DekgoEOrkVE&t=215s", "name": "clip", "type": "tagVideo", "options": ["Preparatory", "Hands", "Left Right", "Wave", "Swim", "Squat and Stretch", "Forward Bow", "Wax on Wax Off", "End Move", "No more moves"], "startTime": "50", "validation": {"isRequired": "A tag is required. If no movement is found, click anytime and select 'No more moves'"}}, {"name": "submit", "type": "submit", "caption": "Submit"}, {"name": "instructions2", "type": "instructions", "modules": [{"type": "instructionsItem", "title": "Instructions", "action": "See Instructions", "modules": {"name": "description", "type": "description", "content": "<h1>How to complete the task</h1><br><h2>Step 1:</h2><br>Watch the video from the beginning and look for the <b>first</b> BDJ movement. You only need to find the first movement. Click 'See Movements' to see our example clips for each movement.<br><br><img width='80%' src='https://puu.sh/C9XPu/83a5a4d4f8.png'><br><h2>Step 2:</h2><br>When you see a BDJ movement click on the timeline where the event occurred. There is a timeline placeholder for your convenience that corresponds to where the video is playing.<br><img width='80%' src='https://puu.sh/C9XPI/28181cf70f.png'><br><h2>Step 3:</h2><br>After you have clicked the timeline, adjust the start and end time of the clip to include the whole movement and nothing else. You can adjust the start and end times on the timeline or by using the input boxes. If you need, click 'See Movements' to see our example clips for each movement so you can properly adjust. Note its okay if the movement doesn't have all the parts of the example or has some repeating parts. It should not have parts not in the example however.<br><img width='80%' src='https://puu.sh/C9Y1S/f2213662ce.png'><br><h2>Step 4:</h2><br>Click the 'Select Label' drop down to label your tag with the correct movement name.<br><img width='80%' src='https://puu.sh/C9XPd/ac80505d69.png'><br><h1>Additional information</h1><br>If there are no movements left in the video click the video at any time and select the label 'No movement'. If you accidentally click the timeline starting your clip, click the x next to the 'Select Label' and the video will begin auto playing again."}}, {"type": "instructionsItem", "title": "Tips", "action": "See Movements", "modules": [{"name": "instructions", "type": "article", "title": "Movements", "content": "Below are videos containing the 8 movements and their tags."}, {"name": "collapsable1", "type": "collapsable", "header": "Preparatory", "modules": {"src": "https://www.youtube.com/watch?v=RSrygA1y_Js&feature=youtu.be", "name": "prep", "type": "tagVideo", "initial": {"end": 105.918278, "tag": "Preparatory", "start": 82.123392}, "readOnly": true}}, {"name": "collapsable2", "type": "collapsable", "header": "Hands", "modules": {"src": "https://www.youtube.com/watch?v=RSrygA1y_Js&feature=youtu.be", "name": "hands", "type": "tagVideo", "initial": {"end": 148.694506, "tag": "Hands", "start": 105.918278}, "readOnly": true}}, {"name": "collapsable3", "type": "collapsable", "header": "Left Right", "modules": {"src": "https://www.youtube.com/watch?v=RSrygA1y_Js&feature=youtu.be", "name": "leftright", "type": "tagVideo", "initial": {"end": 183.331789, "tag": "Left Right", "start": 148.694506}, "readOnly": true}}, {"name": "collapsable4", "type": "collapsable", "header": "Wave", "modules": {"src": "https://www.youtube.com/watch?v=RSrygA1y_Js&feature=youtu.be", "name": "wave", "type": "tagVideo", "initial": {"end": 223.532924, "tag": "Wave", "start": 183.331789}, "readOnly": true}}, {"name": "collapsable5", "type": "collapsable", "header": "Swim", "modules": {"src": "https://www.youtube.com/watch?v=RSrygA1y_Js&feature=youtu.be", "name": "swim", "type": "tagVideo", "initial": {"end": 261.019341, "tag": "Swim", "start": 223.532924}, "readOnly": true}}, {"name": "collapsable6", "type": "collapsable", "header": "Squat and Stretch", "modules": {"src": "https://www.youtube.com/watch?v=RSrygA1y_Js&feature=youtu.be", "name": "squatandstretch", "type": "tagVideo", "initial": {"end": 315.73971, "tag": "Squat and Stretch", "start": 261.019341}, "readOnly": true}}, {"name": "collapsable7", "type": "collapsable", "header": "Forward Bow", "modules": {"src": "https://www.youtube.com/watch?v=RSrygA1y_Js&feature=youtu.be", "name": "forwardbow", "type": "tagVideo", "initial": {"end": 373.232041, "tag": "Forward Bow", "start": 315.73971}, "readOnly": true}}, {"name": "collapsable8", "type": "collapsable", "header": "Wax On Wax Off", "modules": {"src": "https://www.youtube.com/watch?v=RSrygA1y_Js&feature=youtu.be", "name": "waxonwaxoff", "type": "tagVideo", "initial": {"end": 404.326815, "tag": "Wax On Wax Off", "start": 373.232041}, "readOnly": true}}, {"name": "collapsable9", "type": "collapsable", "header": "End Move", "modules": {"src": "https://www.youtube.com/watch?v=RSrygA1y_Js", "name": "endmove", "type": "tagVideo", "initial": {"end": 423.19, "tag": "End Move", "start": 404.32}, "readOnly": true}}]}, {"type": "instructionsItem", "title": "Rules", "action": "See Rules", "modules": {"name": "content", "type": "paragraph", "content": "<ul><li>You will be paid only if the task is verified by an approved Gems Verifier</li><li>You will not use any automated software or scripting to complete this task</li><li>You will follow task rules and instructions</li><li> <a href='https://gems.org/tos.pdf' target='_blank'> You agree to the Gems Terms of Service </a></li><li> <a href='https://gems.org/privacy.pdf' target='_blank'> You agree to the Gems Privacy Policy </a></li></ul>"}}]}]}

Steps to reproduce:

  1. click anywhere on timeline
  2. try to make the timeline block (pink block) the full length of video
  3. When you drag the pink block towards 0 it becomes NaN:NaN:NaN.NaN
kieranoreilly commented 5 years ago

@sslava can we prioritize this issue too?

sslava commented 5 years ago

done