search

expanse-org / go-expanse

Jeffrey Wilcke's Go implementation of the Ethereum y/w paper
GNU Lesser General Public License v3.0
55 stars 19 forks source link

Ethereum derivation path is used instead of Expanse, when launch Mist wallet with connected Trezor #44

Open DimmOFF opened 4 years ago

DimmOFF commented 4 years ago

When I launch Mist Wallet with connected Trezor wallet, it loads the first address from Trezor, but with Ethereum derivation path m/44'/60'/0'/0. It must be m/44'/40'/0'/0 for Expanse. If I'm right, here is where the fix must be done https://github.com/expanse-org/go-expanse/blob/v1.9.x/accounts/hd.go

System information

Gexp version: v1.9.10-stable OS & Version: Windows 10 Commit hash : d57c0cd658a281425c354b6255877b05f40eb366

Expected behaviour

The first Expanse address from derivation path m/44'/40'/0'/0 is loaded

Actual behaviour

The first Ethereum address from derivation path m/44'/60'/0'/0 is loaded

Steps to reproduce the behavior

  1. Connect and unlock Trezor Model T wallet.
  2. Launch Mist Wallet.
  3. See the log file %AppData%\Expanse Wallet\node.log

node.log

chrisfranko commented 3 years ago

If we fix this for Trezor itll break for everything else. Sadly.