Closed markushausammann closed 9 years ago
Can you give me an example of what you're seeing?
If I remove the urlencode, everything looks nice.
I think what is happening is http://php.net/manual/en/function.http-build-query.php is encoding it a second time.
So yeah, we can probably remove that.
Ah yeah, that's it, sure. We either have to switch off the implicit call in the http_build_query (if possible) or write a comment, otherwise it looks as if it's not encoded. I'll take care of it.
I would much rather we rely on http_build_query
.
Ok, let's just add a comment to the other line explaining why there is no urlencode call there.
The wrapper currently does
urlencode()
on the content that is sent to DR.https://github.com/expectedbehavior/php-docraptor/blob/master/src/DocRaptor.php#L176
But DR doesn't decode and instead just prints the whole content as a string. Is that expectedbehavior :smirk: or would it make sense to decode encoded strings?