TME-2253: Update New CloudTrail ACL Configurations

[bachu20]

Description:

Updates the S3 terraform configuration to address a recent change made with respect to how AWS handles defaults for Access Control Lists on S3 buckets. Going forward all new S3 buckets will default their object ownership setting to bucket owner enforced, which means that requests to set/update ACLs will fail as well.

Detailed list or summary of changes made:

• Removes the cloudtrail_bucket_acl configuration. This isn't necessary since this is the default behavior of new S3 buckets.

• Refactors the cloudtrail_access_log_bucket_acl configuration into a S3 bucket policy statement instead of the canned ACL setting.

Steps to test/reproduce the changes in this PR:

• Create a test terraform file (ex. main.tf).

• Implement the following module.

  
  module "expel_aws_cloudtrail_integration" {
  source  = "expel-io/cloudtrail/aws"
  version = "1.3.4"
  
  expel_customer_organization_guid = "<expel_organization_id>"
  enable_organization_trail = false
  }

output "cloudtrail_integration" { value = module.expel_aws_cloudtrail_integration }

- Applying the above configuration should result in an error along the lines of

AccessControlListNotSupported: The bucket does not allow ACLs │ status code: 400