search

expel-io / terraform-aws-eks

Terraform module for configuring EKS to integrate with Expel Workbench.
MIT License
0 stars 2 forks source link

remove `kubernetes` resources #15

Open hall opened 4 months ago

hall commented 4 months ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

According to step 3 of the docs:

Note: As of June 4, 2024, the Expel Security Benchmark Report is no longer supported.

If I understand correctly, this means creation of the kubernetes_cluster_role, kubernetes_cluster_role_binding, along with updating the aws-auth ConfigMap is outdated.

Describe the solution you'd like A clear and concise description of what you want to happen.

Remove the Kubernetes resources along with aws-auth config in docs.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Leave `em :woman_shrugging: they don't hurt anything.

Additional context Add any other context or screenshots about the feature request here.

I'm only weakly convinced this is true so feel free to close if I've missed the mark.

bachu20 commented 3 months ago

@hall Thanks for calling out this potential discrepancy, we have this in our backlog to verify and address.

jakeforge commented 2 weeks ago

Any update on this?