search

experianplc / experian-dotnet

.Net Standard Library for Experian Services
MIT License
7 stars 7 forks source link

Add PremierProfiles call #4

Closed ncsmikewoods closed 6 years ago

ncsmikewoods commented 6 years ago

Added an extension method for the PremierProfiles API.

Note: The PremierProfilesResponse is incomplete. This file should be considered something like a starting point implementation. I wasn't sure how much reuse of the internal structure you'd want so I kept the nested objects in the same file. Also, the majority of the properties are not present as they were not relevant to what I needed.

Lexcess commented 6 years ago

Merging into a separate branch so the work can be completed and merged to master.

ncsmikewoods commented 6 years ago

@Lexcess Just a note but I noticed yesterday I should have added PremierProfiles to the Services collection (ApiExtensions line 51). Without that the actual extension method fails to lookup the environment-specific URL from the dictionary.

Lexcess commented 6 years ago

Thanks for the heads up. We'll modify that when we split out the classes and finish off the attributes.

If you didn't know, until it is merged, you can continue to update a PR by making commits to the source branch. So feel free to do so in the future.

ncsmikewoods commented 6 years ago

Yeah I intended to just got caught up in other things :)

Thanks for the heads up though.

Lexcess commented 6 years ago

No problem. I'm not sure when we'll have the feature finished and tested but you can track the work here: https://github.com/experianplc/experian-dotnet/tree/PremierProfilesUpdate I've already made that change to API Extensions you highlighted.